chore(CI): Tweak version handling for upstream releases - #198
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe build workflow now accepts unprefixed semantic-version and release-candidate tags. It assigns the ChangesVersion tag release flow
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
E2E Test ResultsCommit: 11fc37f |
janisz
left a comment
There was a problem hiding this comment.
I don't like this change as it's not compatible with golang version convention :(
Maybe we can have 2 tags one with v and one without?
9eced44 to
11fc37f
Compare
Description
Standardize git tag format from
v-prefixed (v0.1.0) to bare semver (X.Y.Z) for upstream releases. This aligns with Konflux conventions (which already use bare0.2,0.2.0tags) and establishes a single well-defined format across build systems.Changes:
.github/workflows/build.yml: Update tag trigger pattern fromv[0-9]+.[0-9]+.[0-9]+to bare[0-9]+.[0-9]+.[0-9]+, and add support forX.Y.Z-rc.Npre-release tags. Update thelatestimage tag condition to usestartsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-')— this is needed because the workflow also triggers onmainpushes and PRs (so we must check it's a tag), and pre-release tags like1.0.0-rc.1should not overwritelatest.README.md: Update the Available Tags table to reflect bare1.0.0format instead ofv1.0.0.Validation
make buildsucceedsmake actionlintpasses — workflow YAML is validAI-assisted development prompts
This PR was developed with AI assistance. Below are the prompts used: